Re: Does 'instead of delete' trigger support modification of OLD

From: Eugen Konkov <kes-kes(at)yandex(dot)ru>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>, pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Does 'instead of delete' trigger support modification of OLD
Date: 2019-11-07 09:24:29
Message-ID: 352093181.20191107112429@yandex.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

Hello Eugen,

Thursday, November 7, 2019, 11:20:32 AM, you wrote:

>> I looked in the CREATE TRIGGER manual page and found this:

>> https://www.postgresql.org/docs/12/sql-createtrigger.html
>> If the trigger fires before or instead of the event, the trigger
>> can skip the operation for the current row, or change the row
>> being inserted (for INSERT and UPDATE operations only).

>> I don't see the "(for INSERT and UPDATE operations only)" language in
>> the main trigger documentation,
>> https://www.postgresql.org/docs/current/trigger-definition.html. I have
>> written the attached patch to fix that. Does that help?

> No. If we document that PG does not allow to modify OLD at instead
> of trigger, the we can not implement that. Probably we can put note
> that "currently modification of the trigger row for RETURNING is not
> implemented"

sorry, typo. Please read:
"currently modification of the trigger row for DELETE RETURNING is notimplemented"

>> As far as allowing DELETE to modify the trigger row for RETURNING, I am
>> not sure how much work it would take to allow that, but it seems like it
>> is a valid requite, and if so, I can add it to the TODO list.

> Yes, Add please into TODO the feature to "allowing DELETE to modify the trigger row
> for RETURNING". Becuase, as I have described at first letter, without
> this the RETURNING rows **does not correspond actually deleted data**

> Thank you.

--
Best regards,
Eugen Konkov

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message PG Doc comments form 2019-11-07 14:17:58 Nit: "Immutable" should be "pure"
Previous Message Eugen Konkov 2019-11-07 09:20:32 Re: Does 'instead of delete' trigger support modification of OLD

Browse pgsql-hackers by date

  From Date Subject
Next Message 曾文旌 (义从) 2019-11-07 09:30:27 Re: [Proposal] Global temporary tables
Previous Message Grigory Smolkin 2019-11-07 09:22:28 Re: [proposal] recovery_target "latest"