Re: pgsql: Oops, don't forget to rewind the directory before scanning it to

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Greg Stark <stark(at)mit(dot)edu>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Oops, don't forget to rewind the directory before scanning it to
Date: 2010-02-22 02:30:58
Message-ID: 3507.1266805858@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

stark(at)postgresql(dot)org (Greg Stark) writes:
> Oops, don't forget to rewind the directory before scanning it to fsync files in CREATE DATABASE

This is certainly not right:

+ AllocateDir(fromdir);
if (xldir == NULL)
ereport(ERROR,

There's no guarantee AllocateDir will hand back the same pointer as
it did the previous time.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2010-02-22 02:38:52 Re: pgsql: Oops, don't forget to rewind the directory before scanning it to
Previous Message Greg Stark 2010-02-22 00:11:49 Re: pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2010-02-22 02:38:52 Re: pgsql: Oops, don't forget to rewind the directory before scanning it to
Previous Message David Fetter 2010-02-22 02:06:15 Re: PGXS: REGRESS_OPTS=--load-language=plpgsql