| From: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, boekewurm+postgres(at)gmail(dot)com, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, bharath(dot)rupireddyforpostgres(at)gmail(dot)com |
| Subject: | Re: Add new option 'all' to pg_stat_reset_shared() |
| Date: | 2023-11-15 02:58:38 |
| Message-ID: | 350550211cf7d235cd92e5c7969e8f68@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-11-15 09:47, Michael Paquier wrote:
> On Tue, Nov 14, 2023 at 10:02:32PM +0900, torikoshia wrote:
>> Attached patch.
>
> You have forgotten to update the errhint at the end of
> pg_stat_reset_shared(), where "slru" needs to be listed :)
Oops, attached v2 patch.
>> BTW currently the documentation explains all the arguments of
>> pg_stat_reset_shared() in one line and I feel it's a bit hard to read.
>> Attached patch uses <itemizedlist>.
>
> Yes, this one is a good idea because each target works on a different
> system view so it becomes easier to understand what a target affects,
> so I've applied this bit, without the slru addition.
Thanks!
> --
> Michael
--
Regards,
--
Atsushi Torikoshi
NTT DATA Group Corporation
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-ability-to-reset-pg_stat_slru-in-pg_stat_rese.patch | text/x-diff | 6.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-11-15 03:17:32 | Re: typo in fallback implementation for pg_atomic_test_set_flag() |
| Previous Message | Michael Paquier | 2023-11-15 02:30:41 | Re: A recent message added to pg_upgade |