Re: Configurable location for extension .control files

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Oliver Charles <ollie(at)ocharles(dot)org(dot)uk>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Configurable location for extension .control files
Date: 2013-06-04 20:07:23
Message-ID: 3505.1370376443@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> The only argument with a good bit of merit I can see is that it could
> lead to unexpected extensions being loaded if e.g. hstore isn't
> installed in the normal extension directory but another extension with
> the same name somewhere else.

And just think about the fun you could have with inconsistent files
named hstore--1.0--1.1.sql in different directories. The extension
feature is really really not designed to be able to search a path of
directories.

It presumably wouldn't be terribly hard for Oliver to patch the sources
to look in something other than SHAREDIR/extension/, but I'm not sure
I see the point of inventing a platform-specific name for that
directory; seems like it would mostly just confuse users coming from
other platforms. Instead, what about not treating that directory as
part of the base package in the first place? If you've got the concept
of directories that multiple packages can install into, just make this
be one of those.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-06-04 20:14:22 Re: Improved error message for CREATE EXTENSION patch...
Previous Message Tom Lane 2013-06-04 19:45:26 Re: [PATCH] Add support for TAS/S_UNLOCK for aarch64