Re: pgsql: Enable script to generate preproc.y in build process.

From: "Alex Hunsaker" <badalex(at)gmail(dot)com>
To: "Michael Meskes" <meskes(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Enable script to generate preproc.y in build process.
Date: 2008-11-15 21:53:59
Message-ID: 34d269d40811151353m110a94dbs734d806437467385@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Nov 14, 2008 at 10:11, Michael Meskes <meskes(at)postgresql(dot)org> wrote:
> Log Message:
> -----------
> Enable script to generate preproc.y in build process.
>
> Modified Files:
> --------------
> pgsql/src/interfaces/ecpg/preproc:
> .cvsignore (r1.1 -> r1.2)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/preproc/.cvsignore?r1=1.1&r2=1.2)
> Makefile (r1.137 -> r1.138)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/preproc/Makefile?r1=1.137&r2=1.138)
> pgsql/src/tools/msvc:
> Solution.pm (r1.44 -> r1.45)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/msvc/Solution.pm?r1=1.44&r2=1.45)
>
> --

Hrm this seems to break for me.

"/usr/bin/perl" ./parse.pl . < ../../../../src/backend/parser/gram.y >
preproc.y
bison -d -o preproc.c preproc.y
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing
-fwrapv -g -DECPG_COMPILE -I../include
-I../../../../src/interfaces/ecpg/include -I. -DMAJOR_VERSION=4
-DMINOR_VERSION=5 -DPATCHLEVEL=0 -I../../../../src/include
-D_GNU_SOURCE -c -o preproc.o preproc.c
preproc.y: In function 'base_yyparse':
preproc.y:11201: error: expected ';' before '}' token
make[4]: *** [preproc.o] Error 1

The fix to preproc.y is below, but I don't immediately see how to fix parse.pl

*** src/interfaces/ecpg/preproc/preproc.y.orig 2008-11-15
14:43:24.000000000 -0700
--- src/interfaces/ecpg/preproc/preproc.y 2008-11-15 14:43:29.000000000 -0700
***************
*** 11198,11204 ****
ecpg_xconst: XCONST { $$ = make_name(); } ;

ecpg_ident: IDENT { $$ = make_name(); }
! | CSTRING { $$ = make3_str(make_str("\""), $1, make_str("\"")) }
| UIDENT { $$ = $1; }
;

--- 11198,11204 ----
ecpg_xconst: XCONST { $$ = make_name(); } ;

ecpg_ident: IDENT { $$ = make_name(); }
! | CSTRING { $$ = make3_str(make_str("\""), $1, make_str("\"")); }
| UIDENT { $$ = $1; }
;

> Sent via pgsql-committers mailing list (pgsql-committers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-committers
>

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2008-11-15 22:18:06 pgsql: Add missing semicolon, per grip from Alex Hunsaker.
Previous Message Peter Eisentraut 2008-11-15 20:53:40 pgsql: Fix crash of xmlconcat(NULL) backpatch from 8.4devel

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-11-15 22:06:09 Re: "ORDER BY" clause prevents "UPDATE WHERE CURRENT OF"
Previous Message Tom Lane 2008-11-15 18:43:41 Re: Compiling on HP-UX 10.20 fails