Re: Incorrect "invalid AM/PM string" error from to_timestamp

From: "Alex Hunsaker" <badalex(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Joshua Tolley" <eggyknap(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org, "Brendan Jurd" <direvus(at)gmail(dot)com>
Subject: Re: Incorrect "invalid AM/PM string" error from to_timestamp
Date: 2008-09-25 22:05:04
Message-ID: 34d269d40809251505r6ac84315ncde79e884bbb5fae@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, Sep 25, 2008 at 10:22 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> A likely bet is that this is caused by use of uninitialized memory,
> which happens to have garbage rather than zeroes in it the second
> time through.

Yep both DCH_MC and DCH_US were going past the end of the string
because they still added the length of the string where
from_char_parse_int_len takes care of that for us now...

The attach patch fixes it and tries to improve the "invalid AM/PM
string" a bit by showing the string.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Alex Hunsaker 2008-09-25 22:07:23 Re: Incorrect "invalid AM/PM string" error from to_timestamp
Previous Message Bruce Momjian 2008-09-25 20:57:52 Re: BUG #4436: (E'\\' LIKE E'\\') => f