| From: | "Alex Hunsaker" <badalex(at)gmail(dot)com> |
|---|---|
| To: | "Brendan Jurd" <direvus(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] to_date() validation |
| Date: | 2008-09-10 01:27:14 |
| Message-ID: | 34d269d40809091827le21056co509469c0684f6d55@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
On Mon, Sep 8, 2008 at 2:24 AM, Brendan Jurd <direvus(at)gmail(dot)com> wrote:
> HEAD actually gets this one wrong; in defiance of the documentation it
> returns 2000-09-07. So, it seems to me that the patch shifts the
> behaviour in the right direction.
>
> Barring actually teaching the code that some nodes (like YYYY) can
> take an open-ended number of characters, while others (like MM) must
> take an exact number of characters, I'm not sure what can be done to
> improve this. Perhaps something for a later patch?
Sound good to me and I would probably argue that things like MM should
not be hard coded to take only 2 chars...
But then again to play devils advocate I can just as easily do things
like to_char(...) + '30 months'::interval;
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-09-10 01:28:40 | Re: pg_regress inputdir |
| Previous Message | Alex Hunsaker | 2008-09-10 01:23:03 | Re: hash index improving v3 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alex Hunsaker | 2008-09-10 01:41:40 | Re: [PATCHES] to_date() validation |
| Previous Message | Alex Hunsaker | 2008-09-10 01:23:03 | Re: hash index improving v3 |