Re: [badalex@gmail.com: Re: [BUGS] Problem identifying constraints which should not be inherited]

From: "Alex Hunsaker" <badalex(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: NikhilS <nikkhils(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, "Pg Patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [badalex@gmail.com: Re: [BUGS] Problem identifying constraints which should not be inherited]
Date: 2008-05-07 06:20:37
Message-ID: 34d269d40805062320o4953c4fdn3cf9b66bda2a375c@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

>On Tue, May 6, 2008 at 9:20 PM, Alex Hunsaker <badalex(at)gmail(dot)com> wrote:
>
> >Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Was there any particularly strong reason why you introduced the syscache
> > instead of working with the available indexes?
> >
> > regards, tom lane
>
> None other than the syscache stuff was way easier to work with than
> the 25-50 lines of boilerplate code that Ill need everywhere I use
> CONSTRNAME. (see the hunk to MergeAttributesIntoExistsing for an
> example of what i mean). Not a big deal though, NikhilS was not sure
> about those changes in the first place.
>
> Ill just rip it out for now. Patch forthcoming.
>

Find attached a diff from v4-v5, and a full patch.

src/backend/commands/tablecmds.c | 242 +++++++++++++++++++++++-------------
src/backend/utils/cache/syscache.c | 12 --
src/include/catalog/indexing.h | 2 -
src/include/utils/syscache.h | 1 -
4 files changed, 153 insertions(+), 104 deletions(-)

Currently this loops through all the constraints for a relation (old
behavior of MergeAttributesIntoExisting)... Do you think its worth
adding a non-unique index to speed this up? If so I can whip up a
patch real quick if you think its worth it... else

Attachment Content-Type Size
inherited_constraints_v4-v5.patch application/octet-stream 13.7 KB
inherited_constraints_v5.patch application/octet-stream 63.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2008-05-07 06:22:38 Re: alter + preserving dependencies
Previous Message KaiGai Kohei 2008-05-07 05:52:27 Re: [0/4] Proposal of SE-PostgreSQL patches

Browse pgsql-patches by date

  From Date Subject
Next Message Alex Hunsaker 2008-05-07 06:41:34 Re: [badalex@gmail.com: Re: [BUGS] Problem identifying constraints which should not be inherited]
Previous Message KaiGai Kohei 2008-05-07 05:52:27 Re: [0/4] Proposal of SE-PostgreSQL patches