Re: [PATCH] expand the units that pg_size_pretty supports on output

From: David Christensen <david(dot)christensen(at)crunchydata(dot)com>
To: Shinya11(dot)Kato(at)nttdata(dot)com
Cc: dgrowleyml(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] expand the units that pg_size_pretty supports on output
Date: 2021-06-16 02:59:47
Message-ID: 34C3B8DC-1A40-4CD4-8379-98D320F9A948@crunchydata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


>> I had not really looked at the patch, but if there's a cleanup portion to the same
>> patch as you're adding the YB too, then maybe it's worth separating those out
>> into another patch so that the two can be considered independently.
>
> I agree with this opinion. It seems to me that we should think about units and refactoring separately.
> Sorry for the confusion.

Sure thing, I think that makes sense. Refactor with existing units and debate the number of additions units to include. I do think Petabytes and Exabytes are at least within the realm of ones we should include; less tied to ZB and YB; just included for completeness.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2021-06-16 03:00:57 Re: Duplicate history file?
Previous Message Tom Lane 2021-06-16 02:44:29 Re: Improving isolationtester's data output