| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Max Johnson <max(dot)johnson(at)novatechautomation(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_ctl/miscinit: print "MyStartTime" as a long long instead of long to avoid 2038 problem. |
| Date: | 2024-09-24 20:44:41 |
| Message-ID: | 3486094.1727210681@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> I think we should use INT64_FORMAT here. That'll choose the right length
> modifier for the platform. And I don't think we need to cast MyStartTime,
> since it's a pg_time_t (which is just an int64).
Agreed. However, a quick grep finds half a dozen other places that
are casting MyStartTime to long. We should fix them all.
Also note that if any of the other places are using translatable
format strings, INT64_FORMAT is problematic in that context, and
"long long" is a better answer for them.
(I've not dug in the history, but I rather imagine that this is all
a hangover from MyStartTime having once been plain "time_t".)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-09-24 20:58:08 | Re: pg_ctl/miscinit: print "MyStartTime" as a long long instead of long to avoid 2038 problem. |
| Previous Message | Andres Freund | 2024-09-24 20:30:55 | Re: [PATCH] Add native windows on arm64 support |