Re: A compiling warning in jsonb_populate_record_valid

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Richard Guo <guofenglinux(at)gmail(dot)com>
Subject: Re: A compiling warning in jsonb_populate_record_valid
Date: 2024-01-25 15:15:34
Message-ID: 347162.1706195734@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Amit Langote <amitlangote09(at)gmail(dot)com> writes:
> On Thu, Jan 25, 2024 at 23:57 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> -1 please. We should not break that abstraction for the sake
>> of ignorable warnings on ancient compilers.

> Ignoring the warning was my 1st thought too, because an old discussion I
> found about the warning was too old (2011). The style I adopted in my
> “fix” is used in a few other places too, so I thought I might as well
> go for it.

Oh, well maybe I'm missing some context. What comparable places did
you see?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-01-25 15:19:28 Re: Emit fewer vacuum records by reaping removable tuples during pruning
Previous Message Amit Langote 2024-01-25 15:12:58 Re: A compiling warning in jsonb_populate_record_valid