Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining
Date: 2023-11-19 20:08:24
Message-ID: 3469A042-A3EB-4483-831D-0D8815D4EF41@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On 19 Nov 2023, at 17:05, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> writes:
>> llvmjit: Use explicit LLVMContextRef for inlining
>
> It looks like the v12 back-port of this wasn't quite right:
> canebrake and urutu have both been showing assertion failures
> down inside LLVMContextDispose since it went in. They aren't
> complaining about v13 and later, though.

Ugh, I had missed these =/ Thanks for the heads up!

> No idea what the cause may be, but perhaps the right answer
> is just to revert this and not try to fix the bug in v12?

I'll have a look with fresh eyes in the morning, and hopefully it will be
fixable. If it get's messy it's quite possible that skipping v12 is the best
option.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-11-20 00:26:49 pgsql: Prevent overflow for block number in buffile.c
Previous Message Tomas Vondra 2023-11-19 20:06:30 pgsql: Lock table in DROP STATISTICS