From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | prlw1(at)cam(dot)ac(dot)uk |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [HACKERS] pg_dump disaster |
Date: | 2000-01-21 05:10:21 |
Message-ID: | 3456.948431421@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Patrick Welche <prlw1(at)newn(dot)cam(dot)ac(dot)uk> writes:
> Trying to load a 6 January pg_dumpall file with today's postgresql gives
> many
> invalid command \N
> probably because
> PQexec: you gotta get out of a COPY state yourself.
> db.out4:11621: invalid command \.
> Somehow psql is out of sync and thinks the \N isn't within a COPY block.
The answer appears to be that Perlstein's "nonblocking mode" patches
have broken psql copy, and doubtless a lot of other applications as
well, because pqPutBytes no longer feels any particular compulsion
to actually send the data it's been handed. (Moreover, if it does
do only a partial send, there is no way to discover how much it sent;
while its callers might be blamed for not having checked for an error
return, they'd have no way to recover anyhow.)
I thought these patches should not have been applied without more
peer review, and now I'm sure of it. I recommend reverting 'em.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tatsuo Ishii | 2000-01-21 05:25:41 | Re: [HACKERS] timezone problem? |
Previous Message | Thomas Lockhart | 2000-01-21 04:25:17 | Re: [HACKERS] timezone problem? |