Re: pgsql: Use perl warnings pragma consistently

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Use perl warnings pragma consistently
Date: 2020-04-13 23:39:11
Message-ID: 344c2ca4-b219-86f4-5426-12bb8a4c91ce@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 4/13/20 5:49 PM, Alvaro Herrera wrote:
> On 2020-Apr-13, Tom Lane wrote:
>
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>> Use perl warnings pragma consistently
>> This seems to have broken something or other, as I now get a bunch of
>> warnings while building the docs:
>>
>> ...
>> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 522.
>> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 524.
>> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 526.
>> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 528.
>> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 529.

Oops. Well, I guess that's why warnings are a good idea :-)

> This should fix it.
>

Right.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2020-04-13 23:40:17 pgsql: Harmonize nbtree page split point code.
Previous Message Alvaro Herrera 2020-04-13 21:49:52 Re: pgsql: Use perl warnings pragma consistently