Re: [PATCH] Add function to_oct

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Eric Radman <ericshane(at)eradman(dot)com>, Dag Lem <dag(at)nimrod(dot)no>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Add function to_oct
Date: 2023-01-07 15:29:49
Message-ID: 3448478.1673105389@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

vignesh C <vignesh21(at)gmail(dot)com> writes:
> Few suggestions
> 1) We could use to_oct instead of to_oct32 as we don't have multiple
> implementations for to_oct

That seems (a) shortsighted and (b) inconsistent with the naming
pattern used for to_hex, so I doubt it'd be an improvement.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2023-01-07 15:47:05 Re: [RFC] Add jit deform_counter
Previous Message Zheng Li 2023-01-07 15:28:11 Re: Support logical replication of DDLs