| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_xlogdump |
| Date: | 2013-02-26 16:45:38 |
| Message-ID: | 3435.1361897138@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> Well, it is broken for xlogdump because it needs a sourcetree arround.
> All I personally really want to do is to replace the usual stanza for
> pg_xlogdump with something like:
> ifdef USE_PGXS
> $(error Building pg_xlogdump with PGXS is not supported)
> else
> ...
Seems reasonable. But let's not break the cases that do work. One
of the functions of contrib/ is to serve as models/skeletons for
external modules. If we pull out the "useless" PGXS support then we'll
just be making it that much harder to copy a contrib module and start
doing something useful.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2013-02-26 16:45:50 | Re: "COPY foo FROM STDOUT" and ecpg |
| Previous Message | Andres Freund | 2013-02-26 16:41:51 | Re: pg_xlogdump |