| From: | Dmitry Ivanov <d(dot)ivanov(at)postgrespro(dot)ru> |
|---|---|
| To: | Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Phrase search ported to 9.6 |
| Date: | 2016-03-16 16:38:14 |
| Message-ID: | 3434940.RE8VbBU72A@abook |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Artur
I've made an attempt to fix some of the issues you've listed, although there's
still much work to be done. I'll add some comments later.
> This function has the duplicated piece from the tsvector_setweight()
> from tsvector_op.c. You can define new function for it.
I'm not sure it's worth the trouble. IMO these functions are relatively small
and we won't benefit from extracting the duplicate code.
> These functions was removed in 9acb9007de30b3daaa9efc16763c3bc6e3e0a92d.
> It seems that tsvector_op.c was not synchronized with the master.
Got it, thanks!
--
Dmitry Ivanov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| phrase.patch | text/x-patch | 133.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2016-03-16 16:38:26 | Re: plpgsql - DECLARE - cannot to use %TYPE or %ROWTYPE for composite types |
| Previous Message | Tom Lane | 2016-03-16 16:36:49 | Re: Pushdown target list below gather node (WAS Re: WIP: Upper planner pathification) |