| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Petr Jelinek <pjmodos(at)pjmodos(dot)net> |
| Cc: | Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, Robert Haas <robertmhaas(at)gmail(dot)com>, Abhijit Menon-Sen <ams(at)toroid(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: GRANT ON ALL IN schema |
| Date: | 2009-10-12 18:42:19 |
| Message-ID: | 343.1255372939@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Petr Jelinek <pjmodos(at)pjmodos(dot)net> writes:
> [ latest GRANT ALL patch ]
I started looking at this, and the first thing I noticed was that it
adds TABLES, FUNCTIONS, and SEQUENCES as unreserved keywords. Now
I'm not a fan of bloating the parser that way, but I have to admit
that "GRANT ON ALL TABLE IN SCHEMA" wouldn't read well. What I am
wondering is whether we should not go back and adjust the syntax
for the default-ACLs patch to use the same keywords, ie not
ALTER DEFAULT PRIVILEGES ... GRANT ... ON TABLE TO ...
but
ALTER DEFAULT PRIVILEGES ... GRANT ... ON TABLES TO ...
Comments?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2009-10-12 18:51:20 | Re: EvalPlanQual seems a tad broken |
| Previous Message | Merlin Moncure | 2009-10-12 18:21:49 | Re: Is FOR UPDATE an optimization fence? |