Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data
Date: 2021-08-07 19:00:55
Message-ID: 341252AE-B633-471E-9FF4-B09FC5D036E2@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

> 7 авг. 2021 г., в 20:33, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> написал(а):
>
> <v9-0001-Introduce-TAP-test-for-2PC-with-CIC-behavior.patch>

> <v9-0004-PoC-fix-clear-xid.patch>

> <v9-0003-Fix-CREATE-INDEX-CONCURRENTLY-in-precence-of-vxid.patch>

> <v9-0002-PoC-fix-for-race-in-RelationBuildDesc-and-relcach.patch>

Here's v10.
Changes:
1. Added assert in step 2 (fix for missed invalidation message). I wonder how deep possibly could be RelationBuildDesc() inside RelationBuildDesc() inside RelationBuildDesc() ... ? If the depth is unlimited we, probably, need a better data structure.
2. Editorialised step 3 (vxid->xid lookup). Fixing typos and some small bugs.

Tomorrow I'll try to cleanup step 1 (tap tests).

Thanks!

Best regards, Andrey Borodin.

Attachment Content-Type Size
v10-0004-PoC-fix-clear-xid.patch application/octet-stream 1.0 KB
v10-0003-Fix-CREATE-INDEX-CONCURRENTLY-in-precence-of-vxi.patch application/octet-stream 8.4 KB
v10-0002-PoC-fix-for-race-in-RelationBuildDesc-and-relcac.patch application/octet-stream 2.2 KB
v10-0001-Introduce-TAP-test-for-2PC-with-CIC-behavior.patch application/octet-stream 7.0 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Noah Misch 2021-08-07 22:19:57 Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data
Previous Message Andrey Borodin 2021-08-07 15:33:18 Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data