Re: best way to apply and work on the patches of the pg community

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: mahendrakar s <mahendrakarforpg(at)gmail(dot)com>
Cc: pgsql-novice <pgsql-novice(at)lists(dot)postgresql(dot)org>
Subject: Re: best way to apply and work on the patches of the pg community
Date: 2022-07-15 16:33:34
Message-ID: 3401796.1657902814@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-novice

mahendrakar s <mahendrakarforpg(at)gmail(dot)com> writes:
> I would like to work on a patch published on hackers community( patch is
> from June, 2021). I cloned postgres code and tried to apply the patch and
> got errors.

> *patch -p1 < ../0001-auth-generalize-SASL-mechanisms.patch*
> patching file src/backend/libpq/auth-scram.c
> Hunk #1 FAILED at 101.
> Hunk #2 FAILED at 170.
> Hunk #3 FAILED at 199.
> Hunk #4 FAILED at 215.
> Hunk #5 FAILED at 325.

> Can you please let me know what is the recommended way to apply the patches
> for me to begin the work?

"patch -p1" is the way that usually works the best for me. My guess
here is that the patch in question is out of date and will need manual
adjustment to apply to HEAD. There have been some pretty significant
changes in that code in the last year, eg 9fd85570d.

Sometimes --ignore-whitespace helps, but I doubt that's the main
problem in this case.

regards, tom lane

In response to

Browse pgsql-novice by date

  From Date Subject
Next Message Taka Taka 2022-07-20 06:02:41 Is psqlodbc_13_02 compatible to M365?
Previous Message David G. Johnston 2022-07-15 16:11:40 Re: best way to apply and work on the patches of the pg community