| From: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, jian he <jian(dot)universality(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <pg(at)bowt(dot)ie>, "Finnerty, Jim" <jfinnert(at)amazon(dot)com>, Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, teodor(at)sigaev(dot)ru, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru> |
| Subject: | Re: POC, WIP: OR-clause support for indexes |
| Date: | 2024-06-24 20:33:29 |
| Message-ID: | 3381819.e9J7NaK4W3@thinkpad-pgpro |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
Let me join the review process.
I am no expert in execution plans, so there would not be much help in doing
even better optimization. But I can read the code, as a person who is not familiar
with this area and help making it clear even to a person like me.
So, I am reading v25-0001-Transform-OR-clauses-to-ANY-expression.patch that
have been posted some time ago, and especially transform_or_to_any function.
> @@ -38,7 +45,6 @@
> int from_collapse_limit;
> int join_collapse_limit;
>
> -
> /*
> * deconstruct_jointree requires multiple passes over the join tree, because we
> * need to finish computing JoinDomains before we start distributing quals.
Do not think that removing empty line should be part of the patch
> + /*
> + * If the const node's (right side of operator expression) type
> + * don't have “true†array type, then we cannnot do the
> + * transformation. We simply concatenate the expression node.
> + */
Guess using unicode double quotes is not the best idea here...
Now to the first part of `transform_or_to_any`
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-06-24 20:35:50 | Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin |
| Previous Message | Heikki Linnakangas | 2024-06-24 20:30:53 | Re: Direct SSL connection and ALPN loose ends |