| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, nasbyj(at)amazon(dot)com, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru |
| Date: | 2018-10-02 14:15:28 |
| Message-ID: | 338.1538489728@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> My brain is rather fried for the rest of the day... But we could just
> be looking at using USE_ASSERT_CHECKING. Thoughts from other are
> welcome.
I'd go with folding the condition into a plain Assert. Then it's
obvious that no code is added in a non-assert build. I can see that
some cases might be so complicated that that isn't nice, but this
case doesn't seem to qualify.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-10-02 15:54:59 | pgsql: Fix corner-case failures in has_foo_privilege() family of functi |
| Previous Message | Michael Paquier | 2018-10-02 07:40:34 | pgsql: Fix documentation of pgrowlocks using "lock_type" instead of "mo |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2018-10-02 14:16:12 | Re: Commit fest 2018-09 |
| Previous Message | Tom Lane | 2018-10-02 14:13:48 | Re: Commit fest 2018-09 |