Re: pg_indent instructions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_indent instructions
Date: 2021-06-28 19:29:27
Message-ID: 336667.1624908567@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> The README for pg_indent says:

>     ./configure     # "make" will not work in an unconfigured tree
>     cd src/include/catalog
>     make reformat-dat-files
>     cd ../../..

> This looks like a case of using a sledgehammer to crack a nut.

> I did this, which amounts to the same thing and is faster:

>     cd src/include/catalog
>     perl ./reformat_dat_file.pl --output . ./pg_*.dat
>     cd ../../..

True, that saves having to do a configure run, but it also embeds
some assumptions that personally I could do without --- mainly
about which perl you want to use. In any case, configure is
pretty quick as long as you've got it set up to use a cache file.

One thing we should do, perhaps, is remove the "cd" steps in
favor of recommending

make -C src/include/catalog reformat-dat-files

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Elijah Stone 2021-06-28 19:55:33 Re: Composite types as parameters
Previous Message Andrew Dunstan 2021-06-28 19:23:49 pg_indent instructions