Re: EquivalenceClass and custom_read_write

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: EquivalenceClass and custom_read_write
Date: 2025-02-12 16:55:45
Message-ID: 3352736.1739379345@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> writes:
> In pathnodes.h
> typedef struct EquivalenceClass
> {
> pg_node_attr(custom_read_write, no_copy_equal, no_read, no_query_jumble)

> Because of custom_read_write attribute, I expect _outEquivalenceClass
> to be present in outfuncs.c and _readEquivalenceClass to be present in
> readfuncs.c. I find the first but not the second. This could be
> because _out function is only for debugging and what it writes is
> never read back. Should we add a comment in EquivalenceClass prologue
> mentioning the same?

Doesn't the "no_read" annotation imply exactly that?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dagfinn Ilmari Mannsåker 2025-02-12 16:58:47 Re: TAP test command_fails versus command_fails_like
Previous Message Ranier Vilela 2025-02-12 16:46:38 Re: Small memory fixes for pg_createsubcriber