From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Allow tests to pass in OpenSSL FIPS mode |
Date: | 2023-03-06 14:55:06 |
Message-ID: | 3349278.1678114506@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 5 Mar 2023, at 00:04, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I've gone through this and have a modest suggestion: let's invent some
>> wrapper functions around encode(sha256()) to reduce the cosmetic diffs
>> and consequent need for closer study of patch changes. In the attached
>> I called them "notmd5()", but I'm surely not wedded to that name.
> For readers without all context, wouldn't it be better to encode in the
> function name why we're not just calling a hash like md5? Something like
> fips_allowed_hash() or similar?
I'd prefer shorter than that --- all these queries are laid out on the
expectation of a very short function name. Maybe "fipshash()"?
We could make the comment introducing the function declarations more
elaborate, too.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bharath Rupireddy | 2023-03-06 15:06:17 | Re: Combine pg_walinspect till_end_of_wal functions with others |
Previous Message | tender wang | 2023-03-06 14:50:51 | Re: wrong results due to qual pushdown |