| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Rémi Zara <remi_zara(at)mac(dot)com>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: NetBSD/MIPS supports dlopen |
| Date: | 2008-03-05 20:33:57 |
| Message-ID: | 3345.1204749237@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Rmi Zara wrote:
>> Recent version of NetBSD/MIPS support dlopen. This patch makes the
>> netbsd dynloader tests availability of dlopen on HAVE_DLOPEN rather than
>> on __mips__
> Applied, thanks.
Weird, I haven't seen the commit message come through here.
Anyway: (1) this should probably be back-patched; (2) please clean up
the ugly double negative here:
! #if !defined(HAVE_DLOPEN)
#else
dlclose(handle);
#endif
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bryce Nesbitt | 2008-03-05 21:06:12 | Proposed patch - psql wraps at window width |
| Previous Message | Alvaro Herrera | 2008-03-05 19:43:28 | Re: NetBSD/MIPS supports dlopen |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Edwin Groothuis | 2008-03-05 20:49:22 | Re: [BUGS] BUG #3975: tsearch2 index should not bomb out of 1Mb limit |
| Previous Message | Alvaro Herrera | 2008-03-05 19:43:28 | Re: NetBSD/MIPS supports dlopen |