| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Adjust interaction of CREATEROLE with role properties. |
| Date: | 2023-01-27 15:46:53 |
| Message-ID: | 3332370.1674834413@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> On Fri, Jan 27, 2023 at 08:27:40AM -0500, Andrew Dunstan wrote:
>> On 2023-01-26 Th 22:18, Tom Lane wrote:
>>> Maybe we need to enforce this at some other level than the tests
>>> themselves, perhaps in pg_regress?
>> Yeah, that seems like a better way to go. Then it would even apply to
>> external project tests.
> Maybe this could be done by creating a pg_dump ?
That'd be an amazingly expensive way to do it.
I was imagining that pg_regress could contain a function that
issues some predefined queries and complains if the results
aren't empty. It already has the ability to issue commands
to the cluster-under-test (for the initial CREATE DATABASE etc)
so at least most of the infrastructure is easily at hand.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-01-27 17:13:48 | pgsql: Minor GUC code refactoring. |
| Previous Message | Justin Pryzby | 2023-01-27 15:28:54 | Re: pgsql: Adjust interaction of CREATEROLE with role properties. |