From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: .gitignore files, take two |
Date: | 2010-09-21 15:27:38 |
Message-ID: | 3332.1285082858@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Breaking it up was quite trivial. Here's what I came up with after
> building on my box. I'm sure there are some on other platforms showing
> up, but this should be the majority.
> I just realized it does not include contrib, but's that a mechanical
> copy of the same thing.
> So if we want to go with this way, i have the scripts/changes ready :)
This works for me, modulo some things:
If we are going to ignore *.so at the top level, we also need to ignore
*.sl (for HPUX) and *.dll (for Windows). I also wonder why we have
entries like this:
> +libecpg.a
> +libecpg.so.*
rather than global ignore patterns for *.a and *.so.[0-9]
We should probably ignore src/Makefile.custom, since that is still a
supported way to customize builds (and some of us still use it).
> diff --git a/src/timezone/.gitignore b/src/timezone/.gitignore
> new file mode 100644
> index 0000000..f844c9f
> --- /dev/null
> +++ b/src/timezone/.gitignore
> @@ -0,0 +1 @@
> +/zic
Why does this entry have a / when none of the rest do? Shouldn't
we be consistent about that?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2010-09-21 15:28:58 | moving development branch activity to new git repo |
Previous Message | Robert Haas | 2010-09-21 15:23:36 | Re: Configuring synchronous replication |