| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Remove IS_AF_UNIX macro |
| Date: | 2022-02-16 16:13:35 |
| Message-ID: | 3323700.1645028015@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> On 15.02.22 16:41, Tom Lane wrote:
>> I hadn't looked closely at this patch, but are you referring to
>> this bit in ip.h?
> In src/backend/utils/adt/pgstatfuncs.c there is a use of AF_UNIX that
> has been there unprotected by any #ifdef since about 2008.
Oh, I see it :-(. Poor coding, but it evidently no longer matters.
> Maybe/probably. But there is a difference between platforms having the
> AF_UNIX symbol (which is required by POSIX unconditionally) and
> platforms actually having Unix sockets or not (which might require
> different default configurations or run-time behavior), so the two
> questions are not that closely connected.
Fair point.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2022-02-16 21:15:44 | pgsql: Fix bogus log message when starting from a cleanly shut down sta |
| Previous Message | Peter Eisentraut | 2022-02-16 16:06:12 | Re: pgsql: Remove IS_AF_UNIX macro |