Re: Convert sepgsql tests to TAP

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Joe Conway <mail(at)joeconway(dot)com>
Cc: Andreas Karlsson <andreas(at)proxel(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Convert sepgsql tests to TAP
Date: 2025-01-24 14:00:36
Message-ID: 331ca860-62e9-44ef-94b8-303a5fbeffc7@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2025-01-24 Fr 7:25 AM, Peter Eisentraut wrote:
> On 27.08.24 10:12, Peter Eisentraut wrote:
>> Here is a new patch version.
>>
>> I simplified the uses of sed and awk inside the Perl script.  I also
>> fixed "make installcheck".  I noticed that meson installs sepgsql.sql
>> into the wrong directory, so that's fixed also. (Many of the
>> complications in this patch set are because sepgsql is not an
>> extension but a loose SQL script, of which it is now the only one. 
>> Maybe something to address separately.)
>>
>> I did end up deciding to keep the old test_sepgsql script, because it
>> does have the documented purpose of testing existing installations. 
>> I did change it so that it calls pg_regress directly, without going
>> via make, so that the dependency on make is removed.
>
> This has been committed.  And I understand there is a buildfarm client
> update available for the affected buildfarm members.

This should only be rhinoceros. Joe can pull this fix:
https://github.com/PGBuildFarm/client-code/commit/60b72787036090c6bf829f5cef2b0b3e60f2a2db
(or just copy the whole file from
https://raw.githubusercontent.com/PGBuildFarm/client-code/refs/heads/main/PGBuild/Modules/TestSepgsql.pm)

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2025-01-24 14:11:34 Re: Convert sepgsql tests to TAP
Previous Message Joe Conway 2025-01-24 13:59:03 Re: Replace current implementations in crypt() and gen_salt() to OpenSSL