| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | petr(dot)jelinek(at)2ndquadrant(dot)com, noriyoshi(dot)shinoda(at)hpe(dot)com, pgsql-hackers(at)postgresql(dot)org, craig(at)2ndquadrant(dot)com |
| Subject: | Re: Logical Replication and Character encoding |
| Date: | 2017-04-06 18:43:56 |
| Message-ID: | 330a093a-d155-c866-cbf2-8f36fdf51e95@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/6/17 11:47, Peter Eisentraut wrote:
> On 4/5/17 21:32, Kyotaro HORIGUCHI wrote:
>> At Wed, 5 Apr 2017 11:33:51 -0400, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote in <5401fef6-c0c0-7e8a-d8b1-169e30cbd854(at)2ndquadrant(dot)com>
>>> After further thinking, I prefer the alternative approach of using
>>> pq_sendcountedtext() as is and sticking the trailing zero byte on on the
>>> receiving side. This is a more localized change, and keeps the logical
>>> replication protocol consistent with the main FE/BE protocol. (Also, we
>>> don't need to send a useless byte around.)
>>
>> I'm not sure about the significance of the trailing zero in the
>> the logical replication protocol.
>
> It doesn't matter. It could be "nice" to have it because then the
> receiving side doesn't need to add it if it wants to assemble a C
> string. But for the reasons above, it doesn't seem worth doing that.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2017-04-06 18:46:29 | Re: SCRAM authentication, take three |
| Previous Message | David Steele | 2017-04-06 18:33:46 | Re: increasing the default WAL segment size |