| From: | Elvis Pranskevichus <elprans(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump fails on domain constraint comments |
| Date: | 2016-01-23 23:25:34 |
| Message-ID: | 3307594.KDmpRk6pVS@klinga.prans.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On January 22, 2016 08:09:36 PM Alvaro Herrera wrote:
> Michael Paquier wrote:
> > On Tue, Jan 12, 2016 at 7:56 AM, Elvis Pranskevichus <elprans(at)gmail(dot)com>
wrote:
> > > It looks like pg_dump emits incorrect text for domain constraint
> > > comments:
> > >
> > > Assuming the following structure,
> >
> > Nice catch! qtypname already has fmtId applied to it, so quotes are
> > applied twice to it in this case. I am adding an entry in the next CF
> > with patch marked as ready for committer so as this does not fail into
> > oblivion. A backpatch would be welcome as well.
>
> Yeah, evidently I didn't test that part. Thanks Elvis, applied and
> backpatched to 9.5.
>
> ... Oh, I just noticed you requested this feature back in 2013,
> https://www.postgresql.org/message-id/5310157.yWWCtg2qIU%40klinga.prans.org
> I hope that it's doing what you wanted!
Yes, works like a charm! Thanks for implementing this.
Elvis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Janes | 2016-01-23 23:26:12 | Re: Combining Aggregates |
| Previous Message | Tom Lane | 2016-01-23 23:04:38 | Re: Proposal: Trigonometric functions in degrees |