Re: libpq stricter integer parsing

On 11/09/2018 11:00, Michael Paquier wrote:
> diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
> index 5e7931ba90..bc7836d103 100644
> --- a/doc/src/sgml/libpq.sgml
> +++ b/doc/src/sgml/libpq.sgml
> @@ -1591,6 +1591,15 @@ postgresql://%2Fvar%2Flib%2Fpostgresql/dbname
> </varlistentry>
> </variablelist>
> </para>
> +
> + <para>
> + Integer values expected for keywords <literal>port</literal>,
> + <literal>connect_timeout</literal>, <literal>keepalives_idle</literal>,
> + <literal>keepalives_interval</literal> and
> + <literal>keepalives_timeout</literal> are parsed more strictly as
> + of <product>PostgreSQL<product> 12, i.e. values including trailing garbage
> + or overflowing are rejected.
> + </para>
> </sect2>
> </sect1>

I would leave this out. We don't need to document every single
refinement of parsing rules. This might better belong in the release notes.

> + appendPQExpBuffer(&conn->errorMessage,
> + libpq_gettext("invalid value for keyword \"%s\"\n"),
> + context);

Add the actual invalid value to the error message.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services