Re: Return value of PathNameOpenFile()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Antonin Houska <ah(at)cybertec(dot)at>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Return value of PathNameOpenFile()
Date: 2022-09-06 19:44:49
Message-ID: 3278205.1662493489@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> Doh, of course. The attached is a quick (lightly make check tested) take on
> allowing 0, but I'm not sure that's what we want?

Actually, wait a second. At least some of these are not dealing
with kernel FDs but with our "virtual FD" abstraction. For those,
zero is indeed an invalid value. There might well be some "<= 0"
versus "< 0" errors in this area, but it requires closer inspection.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2022-09-06 20:15:17 Re: Adding CI to our tree
Previous Message Robert Haas 2022-09-06 19:08:09 Re: has_privs_of_role vs. is_member_of_role, redux