Re: pgsql: libpq: Notice errors a backend may have sent just before dying.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: libpq: Notice errors a backend may have sent just before dying.
Date: 2015-11-12 14:29:29
Message-ID: 32700.1447338569@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Robert Haas <rhaas(at)postgresql(dot)org> writes:
> libpq: Notice errors a backend may have sent just before dying.
> At least since the introduction of Hot Standby, the backend has
> sometimes sent fatal errors even when no client query was in
> progress, assuming that the client would receive it. However,
> pqHandleSendFailure was not in sync with this assumption, and
> only tries to catch notices and notifies. Add a parseInput call
> to the loop there to fix.

Just for the record, this patch changes no behavior whatsoever.
It could only make a difference if the backend were still actively
sending data, which certainly isn't so in the case claimed by the
commit message. Moreover, removing the comment that explains why
only NOTICE and NOTIFY messages will be eaten doesn't make it not so.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2015-11-12 15:46:00 Re: pgsql: libpq: Notice errors a backend may have sent just before dying.
Previous Message Robert Haas 2015-11-12 14:17:16 pgsql: libpq: Notice errors a backend may have sent just before dying.