From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
Cc: | Postgres Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Make message strings in fe-connect.c consistent |
Date: | 2023-04-21 04:31:01 |
Message-ID: | 3269965.1682051461@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Gurjeet Singh <gurjeet(at)singh(dot)im> writes:
> When reviewing a recently committed patch [1] I noticed the odd usage
> of a format specifier:
> + libpq_append_conn_error(conn, "invalid %s value: \"%s\"",
> + "load_balance_hosts",
> + conn->load_balance_hosts);
> The oddity is that the first %s is unnecessary, since the value we
> want there is a constant. Typically a format specifier used to get the
> value stored in a variable.
This is actually intentional, on the grounds that it reduces the
number of format strings that require translation.
> There's just one exception to this pattern, though.
>> libpq_append_conn_error(conn, "invalid require_auth method: \"%s\"",
>> method);
Yup, this one did not get the memo.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Gurjeet Singh | 2023-04-21 05:02:35 | Re: Make message strings in fe-connect.c consistent |
Previous Message | Gurjeet Singh | 2023-04-21 04:28:01 | Make message strings in fe-connect.c consistent |