| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pq_setkeepalives* functions |
| Date: | 2010-03-13 17:10:47 |
| Message-ID: | 3269.1268500247@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> This is making things worse, not better. You have just changed the
>> behavior, and not in a good way. Formerly these were no-ops on
>> a unix socket connection, and now they can throw errors.
> Is this the proper way to fix the issue? Patch attached.
AFAICS there is no issue, and the code is fine as-is.
Modifying the "get" functions as you propose would be harmless, but it's
also not an improvement, since it would result in redundant code in the
functions when those macros aren't defined.
I don't see any real advantage in making the set and get functions
look slightly more alike. They're doing different things.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-03-13 17:18:32 | Re: Dyamic updates of NEW with pl/pgsql |
| Previous Message | Bruce Momjian | 2010-03-13 17:02:06 | Re: pq_setkeepalives* functions |