Re: Code cleanup for build_regexp_split_result

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Li Japin <japinli(at)hotmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Code cleanup for build_regexp_split_result
Date: 2020-01-16 16:33:44
Message-ID: 32668.1579192424@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Li Japin <japinli(at)hotmail(dot)com> writes:
> I find the build_regexp_split_result() has redundant codes, we can move it to before the condition check, can we?

Hm, yeah, that looks a bit strange. It was less strange before
c8ea87e4bd950572cba4575e9a62284cebf85ac5, I think.

Pushed with some additional simplification to get rid of the
rather ugly (IMO) PG_USED_FOR_ASSERTS_ONLY variable.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-01-16 16:43:34 Re: SlabCheck leaks memory into TopMemoryContext
Previous Message Tomas Vondra 2020-01-16 16:25:00 Re: SlabCheck leaks memory into TopMemoryContext