| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Use the terminology "WAL file" not "log file" more consistently. |
| Date: | 2022-09-15 13:53:14 |
| Message-ID: | 3264633.1663249994@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> writes:
> Thanks for pointing it out. It seems like a good idea IMO. I think
> pg_resetwal also needs the --machine approach. As --machine approach
> needs a good amount of refactoring and discussion, I still think we
> can make buildfarm happy by fixing a proposed solution [1]. Perhaps,
> we can start a new thread for --machine approach.
Agreed; here on -committers is certainly no place for that.
For the moment I'm just going to revert the change in pg_controldata
output, because it occurred to me that pg_upgrade might not be the
only tool side-swiped by that. We can put it back after we have
some more-stable output format that such tools can start using.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-09-15 14:58:11 | pgsql: Revert ill-considered change in pg_resetwal output. |
| Previous Message | Noah Misch | 2022-09-15 13:46:01 | pgsql: Reset InstallXLogFileSegmentActive after walreceiver self-initia |