| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Fix field order in struct catcache. |
| Date: | 2017-01-13 13:35:59 |
| Message-ID: | 32592.1484314559@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> Somebody failed to grasp the point of having the #ifdef CATCACHE_STATS
>> fields at the end of the struct. Put that back the way it should be,
>> and add a comment making it more explicit why it should be that way.
> Actually, the CATCACHE_STATS was added purposefully not at end of
> struct, because back then cc_bucket was a variable-length array; see
> commit 786340441706 (2002). It only became possible to do this after
> commit 20cb18db4668 (2013). I researched this because I vaguely
> believed this to be my fault (a66ee69ad) but that's not so.
Hah, okay. Well, it's better now than it was.
(Actually, I wonder why we expose struct catcache to the rest of the
world at all.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-01-13 18:37:58 | pgsql: Fix cardinality estimates for parallel joins. |
| Previous Message | Alvaro Herrera | 2017-01-13 13:30:55 | Re: [COMMITTERS] pgsql: Fix field order in struct catcache. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anastasia Lubennikova | 2017-01-13 13:36:37 | IF NOT EXISTS option for CREATE SERVER and CREATE USER MAPPING statements |
| Previous Message | Alvaro Herrera | 2017-01-13 13:30:55 | Re: [COMMITTERS] pgsql: Fix field order in struct catcache. |