Re: pg_createsubscriber TAP test wrapping makes command options hard to read.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: "Euler Taveira" <euler(at)eulerto(dot)com>, "Peter Smith" <smithpb2250(at)gmail(dot)com>, "Michael Paquier" <michael(at)paquier(dot)xyz>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Peter Eisentraut" <peter(at)eisentraut(dot)org>, "Euler Taveira" <euler(dot)taveira(at)enterprisedb(dot)com>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
Date: 2025-01-21 02:02:42
Message-ID: 3259117.1737424962@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari(at)ilmari(dot)org> writes:
> All in all, this makes me +0.5 to bumping the required Perl::Tidy
> version, and +0.5 on (at least considering) bumping it to the latest
> version before the pre-release-branch pgperltidy run.

Nah, I'm pretty much -1 on bumping our perltidy version frequently.
That imposes costs on every developer who wants to track it.
It's unlikely that anyone will be on a platform that updates it
exactly when we decide to change, so most of us are going to be
using hand-installed copies that will have to be hand-updated
whenever we change versions.

As a data point, we were using 20170521 for five years before
adopting 20230309, and 20090616 for seven years before that,
which is as far back as I can trace any definitive info about
which version was being used. Every five years or so sounds
like a sane cadence to me, in terms of developer overhead
versus likely formatting improvements.

(Of course, if a new version comes out that is way better than
what we're using, I could be persuaded that it's worth changing.
But from what you're showing here, that hasn't happened yet.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Corey Huinker 2025-01-21 02:25:14 Re: Statistics Import and Export
Previous Message Tom Lane 2025-01-21 01:44:07 Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options