From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Add a GUC check hook to ensure summarize_wal cannot be enabled when wal_level is minimal |
Date: | 2024-07-03 15:16:42 |
Message-ID: | 3253790.1720019802@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> This sort of thing comes up enough that perhaps we should add a
> better-supported way to deal with GUCs that depend on each other...
Yeah, a GUC check hook that tries to inspect the value of some
other GUC is generally going to create more problems than it
solves; we've learned that the hard way in the past. We have
your patch to remove one instance of that on the CF queue:
https://www.postgresql.org/message-id/flat/ZnMr2k-Nk5vj7T7H(at)nathan
But that fix only works because those GUCs are PGC_POSTMASTER
and so we can perform a consistency check on them after GUC setup.
I'm not sure what a more general consistency check mechanism would
look like, but it would have to act at some other point than the
check_hooks do.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2024-07-03 15:21:23 | Re: Commitfest manager for July 2024 |
Previous Message | Jelte Fennema-Nio | 2024-07-03 15:01:40 | Re: Add a GUC check hook to ensure summarize_wal cannot be enabled when wal_level is minimal |