Re: CREATE SUBSCRIPTION log noise

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CREATE SUBSCRIPTION log noise
Date: 2017-06-21 18:14:38
Message-ID: 3242bf64-0f11-2790-ec28-dacf9d21209e@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 6/20/17 22:54, Jeff Janes wrote:
> I think this should go away:
>
> ereport(NOTICE,
> (errmsg("created replication slot \"%s\" on
> publisher",
> slotname)));
>
> It doesn't appear to be contingent on anything other than the content of
> the command you just gave it. I don't think we need a NOTICE saying
> that it did that thing I just told it to do--that should be implicit by
> the lack of an ERROR.

I'm appreciative of this complaint. The point is that we are allocating
resources on a remote host that should not be forgotten. I could go
either way.

Other opinions?

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2017-06-21 18:20:36 Re: pg_bsd_indent 2.0 is available from git.postgresql.org
Previous Message Andres Freund 2017-06-21 18:04:49 Fast promotion not used when doing a recovery_target PITR restore?