Re: Domain checks not always working when used in compound type

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Holger Jakobs <holger(at)jakobs(dot)com>
Cc: "[PGSQL-ADMIN-LIST]" <pgsql-admin(at)postgresql(dot)org>
Subject: Re: Domain checks not always working when used in compound type
Date: 2023-12-29 19:49:26
Message-ID: 3236280.1703879366@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-admin

Holger Jakobs <holger(at)jakobs(dot)com> writes:
> -- Using the domain within a compound type. The NOT NULL constraint
> should be
> -- inherited from the domain, therefore not repeated here for column a.
> CREATE TYPE compound_ab AS (
>   a    domain_a,
>   b    varchar(10)
> );

You are assuming in effect that a simple NULL value for a composite
type is the same thing as ROW(NULL, NULL). They are not quite the
same, and one way in which they are not is that we don't consider
field-level constraints when deciding if a simple NULL value is legal
for the composite -- it always is. Thus

regression=# select null::compound_ab;
compound_ab
-------------

(1 row)

regression=# select row(null, null)::compound_ab;
ERROR: domain domain_a does not allow null values

The SQL spec itself is pretty schizophrenic about whether ROW(NULL, NULL)
is equivalent to bare NULL. This is how we've chosen to interpret it.
I'll freely admit that there's some implementation considerations
involved in that choice, but we're unlikely to revisit it.

If you don't want things to work like this, you could attach a NOT
NULL constraint to the test1.ab column (as well as having the domain
constraint).

regards, tom lane

In response to

Responses

Browse pgsql-admin by date

  From Date Subject
Next Message Holger Jakobs 2023-12-29 19:56:12 Re: Domain checks not always working when used in compound type
Previous Message Holger Jakobs 2023-12-29 19:28:31 Domain checks not always working when used in compound type