| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Sait Talha Nisanci <Sait(dot)Nisanci(at)microsoft(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Metin Doslu <Metin(dot)Doslu(at)microsoft(dot)com> |
| Subject: | Re: Crash in record_type_typmod_compare |
| Date: | 2021-03-31 17:10:50 |
| Message-ID: | 3229167.1617210650@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Sait Talha Nisanci <Sait(dot)Nisanci(at)microsoft(dot)com> writes:
>> We should probably do HASH_ENTER<https://github.com/postgres/postgres/blob/1509c6fc29c07d13c9a590fbd6f37c7576f58ba6/src/backend/utils/cache/typcache.c#L1974> only after we have a valid entry so that we don't end up with a NULL entry in the cache even if an intermediate error happens. I will share a fix in this thread soon.
> I am attaching this patch.
I see the hazard, but this seems like an expensive way to fix it,
as it forces two hash searches for every insertion. Couldn't we just
teach record_type_typmod_compare to say "not equal" if it sees a
null tupdesc?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-03-31 17:11:55 | Re: pg_amcheck contrib application |
| Previous Message | Robert Haas | 2021-03-31 17:01:38 | Re: making update/delete of inheritance trees scale better |