| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: incorrect xlog.c coverage report |
| Date: | 2019-05-31 17:30:58 |
| Message-ID: | 32188.1559323858@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> I forgot to mention that this patch produces a new warning:
> /pgsql/source/master/src/backend/tcop/postgres.c: In function 'quickdie':
> /pgsql/source/master/src/backend/tcop/postgres.c:2737:2: warning: implicit declaration of function '__gcov_flush'; did you mean 'pq_flush'? [-Wimplicit-function-declaration]
> __gcov_flush();
> ^~~~~~~~~~~~
> pq_flush
> I couldn't find a way to squelch that. gcc devs in their infinite
> wisdom don't provide a prototype for it, apparently.
Ugh. So let's supply our own prototype, presumably it's just
extern void __gcov_flush(void);
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2019-05-31 17:34:17 | Re: Comment typo in tableam.h |
| Previous Message | Alvaro Herrera | 2019-05-31 17:05:03 | Re: incorrect xlog.c coverage report |