Re: Coding help

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Coding help
Date: 2003-11-09 15:10:06
Message-ID: 3205.1068390606@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
> | COMMENT ON LARGE OBJECT NumericOnly IS comment_text
> n->objname = makeList1(makeAConst($5));

Forget the makeAConst step --- it's just wasted cycles. In the
execution routine, you can use code comparable to define.c's defGetInt64()
to convert the Value node into a numeric OID, ie, either do intVal() or
a call of oidin().

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-11-09 15:18:18 Re: [HACKERS] BEGIN vs START TRANSACTION
Previous Message Bruce Momjian 2003-11-09 14:12:46 Re: Coding help