| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Addition of --no-sync to pg_upgrade for test speedup |
| Date: | 2021-12-17 09:21:04 |
| Message-ID: | 31d956d7-8854-811d-5797-bf0b30745de7@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 16.12.21 07:50, Michael Paquier wrote:
> As per $subject, avoiding the flush of the new cluster's data
> directory shortens a bint the runtime of the test. In some of my slow
> VMs, aka Windows, this shaves a couple of seconds even if the bulk of
> the time is still spent on the main regression test suite.
>
> In pg_upgrade, we let the flush happen with initdb --sync-only, based
> on the binary path of the new cluster, so I think that we are not
> going to miss any test coverage by skipping that.
I think that is reasonable.
Maybe we could have some global option, like some environment variable,
that enables the "sync" mode in all tests, so it's easy to test that
once in a while. Not really a requirement for your patch, but an idea
in case this is a concern.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2021-12-17 09:46:14 | RE: Column Filtering in Logical Replication |
| Previous Message | Peter Eisentraut | 2021-12-17 09:17:09 | Re: Transparent column encryption |