From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Idea for improving buildfarm robustness |
Date: | 2015-09-29 19:07:04 |
Message-ID: | 319.1443553624@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>> I wouldn't want to do this every time through the postmaster's main loop,
>> but we could do this once an hour for no added cost by adding the check
>> where it does TouchSocketLockFiles; or once every few minutes if we
>> carried a separate variable like last_touch_time. Once an hour would be
>> plenty to fix the buildfarm's problem, I should think.
> I have a bad (?) habit of doing exactly this during development and
> would really like it to be a bit more often than once/hour, unless
> there's a particular problem with that.
Yeah, Josh mentioned the same. It would only take another three or four
lines of code to decouple it from TouchSocketLockFiles, and then it's
just a question of how much are you worried about the performance cost of
additional file-open attempts. I think either one-minute or five-minute
intervals would be pretty defensible.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2015-09-29 19:08:01 | Re: Idea for improving buildfarm robustness |
Previous Message | Stephen Frost | 2015-09-29 18:57:49 | Re: Idea for improving buildfarm robustness |