Re: pgsql: Add PSQL_WATCH_PAGER for psql's \watch command.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <tmunro(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add PSQL_WATCH_PAGER for psql's \watch command.
Date: 2021-07-13 00:30:48
Message-ID: 3187588.1626136248@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Thomas Munro <tmunro(at)postgresql(dot)org> writes:
> To make \watch react quickly when the user quits the pager or presses
> ^C, and also to increase the accuracy of its timing and decrease the
> rate of useless context switches, change the main loop of the \watch
> command to use sigwait() rather than a sleeping/polling loop, on Unix.

I think this is going to fall over on gaur, which doesn't have POSIX-style
sigwait. We've escaped dealing with that so far because our only existing
use of sigwait is hidden under

#if defined(ENABLE_THREAD_SAFETY) && !defined(WIN32)

Perhaps the easiest answer is to make the #if conditional for this
code look like that too.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2021-07-13 00:40:38 pgsql: Fix theoretical bug in tuplesort
Previous Message Thomas Munro 2021-07-12 23:53:32 pgsql: Add PSQL_WATCH_PAGER for psql's \watch command.